-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SettingToggle]: Implement accessibility role and attributes #5470
Conversation
👋 Thanks for opening your first pull request. A contributor should give feedback soon. If you haven’t already, please check out the contributing guidelines. |
size-limit report 📦
|
@chloerice / @alex-page do you know who I should ping to get this reviewed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. Thanks @joelzwarrington
…ction describe block
874f872
to
72b1785
Compare
|
🎉 Thanks for your contribution to Polaris! |
WHY are these changes introduced?
Fixes #5462
WHAT is this pull request doing?
aria-checked
attribute to be passed to<Button />
switch
aria-checked
attributes on Setting Action based onenabled
valueswitch
with the content passed in as childrenScreenshot showing which sub-component becomes the label & switch
There should be no visual change in this PR to the SettingToggle component.
SettingToggle.-.Confirming.aria.checked.interaction.mov
How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
Copy-paste this code in
playground/Playground.tsx
:🎩 checklist
README.md
with documentation changes