This repository has been archived by the owner on Oct 1, 2024. It is now read-only.
Put minus sign in front of currency symbol formatting negative amounts #1264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cejaekl
force-pushed
the
format_currency_minus_signs_2020-02-06
branch
3 times, most recently
from
90aac42
to
5de444c
Compare
…mounts (Placate lint) (Fix duplicated test names) (Updated CHANGELOG.md)
cejaekl
force-pushed
the
format_currency_minus_signs_2020-02-06
branch
from
5de444c
to
2c0e30e
Compare
ismail-syed
reviewed
Feb 12, 2020
| ? `${shortSymbol.symbol}${formattedAmount}` | ||
| : `${formattedAmount}${shortSymbol.symbol}`; | ||
|
|
||
| return amount < 0 | ||
| ? `-${formattedWithSymbol.replace('-', '')}` |
There was a problem hiding this comment.
Are there any possible formats of formattedWithSymbol where a - would denote something that is not a minus symbol? I see 1 234,56 Kč CZK, could there ever be a format of money that would result in 1 234,56 foo-bar
There was a problem hiding this comment.
I think we're "safe" to do this.
- We should always have
-as theminus sign. Looking at the Unicode CLDR data, every single locale for which it defines aminus_sign:uses- - We should never have a
-in this string that isn't aminus sign. We're dealing with the "symbol" for the currency, or potentially the ISO-4217 currency code (which is guaranteed to be three alphabetic letters).
It's possible that a - might show up in the full-text name of the currency (e.g. Guinea-Bisseau franc), but we won't have the full name here, only the symbol or the three-letter code.
ismail-syed
approved these changes
Feb 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1234
Changes the output of
i18n.formatCurrency(-3.25)from$-3.25to-$3.25, to conform with our new currency formatting guidelines:https://polaris.shopify.com/foundations/formatting-localized-currency
Type of change
Changes
react-i18n'si18n.formatCurrency().react-i18nPatch: Minor change in formatting output. Really too small to be considered "breaking".Checklist