Update exclude of tsbuildinfo files #1982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lerna v3 to v4 update included a major update to `npm-packlist`, which controls what files get packaged into the tar file when publishing. In npm-packlist v2 `*.tsbuildconfig` no longer excludes the `build/tsconfig.tsbuildconfig` file, we need to give the fuller path to ensure this file is not uploaded to the npm registry.
BPScott
force-pushed
the
remove-tsbuildinfo
branch
from
62b3f35
to
40ecb30
Compare
BPScott
force-pushed
the
remove-tsbuildinfo
branch
from
40ecb30
to
9128cab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lerna v3 to v4 update included a major update to
npm-packlist,which controls what files get packaged into the tar file when
publishing. In npm-packlist v2
*.tsbuildinfono longer excludes thebuild/tsconfig.tsbuildinfofile, we need to give the fuller path toensure this file is not uploaded to the npm registry.
See npm/npm-packlist#39
You can prove that the exclude is now working by doing
cd packages/addressthennpx npm-packlistand noting that the buildbuild/tsconfig.tsbuildinfofile is no longer present in the list of returned items