Simpify babel config slightly #2593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves preset-env plugins to be included as part of the preset-env pass rather than separatly - which is now possible because we've dropped decorator support. This does produce some output changes in production builds - mostly removing cases where class properties were needlessly initialize to undefined.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This moves preset-env plugins to be included as part of the preset-env pass rather than separately - which is now possible because we've dropped decorator support.
This does produce some slight output changes in production builds - mostly removing cases where class properties were needlessly initialized.
To test
Compare build output to previous builds:
~/projects/quiltdirectory and runyarn,yarn clean && yarn buildto produce a clean build~/src/github.com/Shopify/quiltdirectory and runyarn,yarn clean && yarn buildto produce a clean buildfor PACKAGENAME in $(ls -1 packages); diff -ru ~/projects/quilt/packages/$PACKAGENAME packages/$PACKAGENAME -x '*.tsbuildinfo' -x '*.d.ts.map'to compare the build folder output.void 0for class properties. In the majority of these cases the property was set to be a defined value shortly below the removed line.