This repository has been archived by the owner on Oct 1, 2024. It is now read-only.
Allow custom error handling for i18n errors #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TzviPM
reviewed
Mar 5, 2019
| return translate(id, normalizedOptions, this.translations, this.locale); | ||
| } catch (error) { | ||
| this.onError(error); | ||
| return ''; |
There was a problem hiding this comment.
Should we make the consumer supply a component for this? Maybe some sort of empty state is better than the empty string? Like a line that looks like it never loads?
There was a problem hiding this comment.
I think this gets really tricky because then you probably want a bunch of context about the type of error and other info. These errors should be rare and dealt with immediately, so I think this is enough to get that done.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, when a translation is missing (or in a few other cases), we throw an error from the i18n library and are done with it. IMO this is the proper default; React provides ways to catch this error in the tree and recover gracefully. However, Web has been bitten a few times by this where incomplete test coverage/ being a little careless with the translations + no additional error handling means that the whole page gets wiped.
This PR adds the necessary hook for us to catch the error. With this PR, if the error is not re-thrown by the
onErrorhandler, it will return an empty string instead. IMO this is not really better than the default (since the content will not make sense), and it means that in some cases we still have errors thrown (where we can't return any sensible "default" result), but I seem to be in the minority opinion on this.