Merge pull request #1682 from Shopify/on-size-copy

Update size identity in onSize
Shopify · Jun 28, 2023 · 3477306 · 3477306
2 parents f3c1376 + d74fd76
commit 3477306
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/package/cpp/rnskia/RNSkView.h b/package/cpp/rnskia/RNSkView.h
@@ -379,9 +379,11 @@ class RNSkView : public std::enable_shared_from_this<RNSkView> {
 
                 if (w != width || h != height) {
                   // Update
-                  onSizeObj.setProperty(*runtime, "width", width);
-                  onSizeObj.setProperty(*runtime, "height", height);
-                  self->_onSize->set_current(*runtime, onSize);
+                  auto newValue = jsi::Object(*runtime);
+                  newValue.setProperty(*runtime, "width", width);
+                  newValue.setProperty(*runtime, "height", height);
+                  self->_onSize->set_current(*runtime,
+                                             jsi::Value(*runtime, newValue));
                 }
               }
             }