#1658: Removed inclusion of TurboModuleUtils.h #1670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is no longer (RN 0.72) possible to include and uses TurboModulesUtils without a lot of trouble when use_frameworks are true in POD file. Instead we're now just including the implementations ourselves.
wcandillon
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is no longer (from RN 0.72) possible to include and uses TurboModulesUtils without a lot of trouble when use_frameworks are true in POD file.
Instead we're now just including the implementations ourselves. TurboModuleUtils contains simple wrappers for JSI Promises that we're using when loading data like images etc.
This problem only occurs when use_frameworks is set in the POD file - so testing must be done using this setting. (this causes all include files to be flattened)
Fixes #1658