馃帹 Native color parsing #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrfalch
requested changes
Apr 20, 2022
package/src/skia/Skia.ts
Outdated
| } | ||
| let color = Skia.parseColorString(cl); | ||
| if (color === undefined) { | ||
| console.warn("Skia couldn't parse the following color " + cl); |
There was a problem hiding this comment.
Should we add an explanation here - like "This might affect your drawing performance since the colour will be evaluated in Javascript instead of on the native side at runtime"
chrfalch
approved these changes
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the review commands of #400