Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Path Commands #422

Merged
merged 15 commits into from
Apr 22, 2022
Merged

Add support for Path Commands #422

merged 15 commits into from
Apr 22, 2022

Conversation

wcandillon
Copy link
Collaborator

These two methods to roundtrip from commands to paths are symmetric with CanvasKit

@wcandillon wcandillon self-assigned this Apr 21, 2022
package/cpp/api/JsiSkPathFactory.h Show resolved Hide resolved
package/cpp/api/JsiSkPath.h Outdated Show resolved Hide resolved
package/cpp/api/JsiSkPath.h Show resolved Hide resolved
package/cpp/api/JsiSkPathFactory.h Outdated Show resolved Hide resolved
package/cpp/api/JsiSkPathFactory.h Outdated Show resolved Hide resolved
package/cpp/api/JsiSkPathFactory.h Show resolved Hide resolved
package/src/skia/Path/PathFactory.ts Show resolved Hide resolved
@wcandillon
Copy link
Collaborator Author

Implemented the review comments 🙌🏼

Copy link
Collaborator

@chrfalch chrfalch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wcandillon wcandillon merged commit ab912f7 into main Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants