Fix & refactor script build-skia-ios-fatlibs
#53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
needs to check for existence of iOS libs instead of the Android ones
ghost
added
the
schiller-manuel
force-pushed
the
fix-refactor-build-skia-ios-fatlibs
branch
from
b2aa927
to
55cf482
Compare
use values from configuration
schiller-manuel
force-pushed
the
fix-refactor-build-skia-ios-fatlibs
branch
from
55cf482
to
b55c07e
Compare
|
Hi @schiller-manuel ! Thanks so much for helping out :) Just wanted to discuss what error this PR is targeting - I see your point using the configuration instead of hard coded values - but did this result in a failure in the build system? Just asking to make sure I understand the problem :) :) Christian |
chrfalch
approved these changes
Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing this script to be able to build the library