-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix velocity regression & bug #798
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
16634df
Fix velocity regression
wcandillon 9baa40b
Add test case
wcandillon 8fc442b
Add test case
wcandillon 5f575b2
Add Failing test case
wcandillon 6e2a67b
Merge branch 'main' into fix-velocity-regression
wcandillon f1b05ff
Update test suite
wcandillon b6342b6
Merge branch 'fix-velocity-regression' of github.com:Shopify/react-na…
wcandillon 1dc92f4
Merge branch 'main' into fix-velocity-regression
wcandillon bb33078
Update tests
wcandillon c685faf
Remove uncessary use of any
wcandillon File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,113 @@ | ||
import React from "react"; | ||
|
||
import { TouchType } from "../../views/types"; | ||
|
||
import type { EmptyProps } from "./setup"; | ||
import { mountCanvas, importSkia } from "./setup"; | ||
|
||
const SimpleActiveTouch = ({}: EmptyProps) => { | ||
const { useTouchHandler } = importSkia(); | ||
const touchHandler = useTouchHandler({ | ||
onStart: ({ x, y }) => { | ||
expect(x).toBe(10); | ||
expect(y).toBe(10); | ||
}, | ||
onActive: ({ x, y, velocityX, velocityY }) => { | ||
expect(x).toBe(20); | ||
expect(y).toBe(20); | ||
expect(velocityX).toBe(10); | ||
expect(velocityY).toBe(10); | ||
}, | ||
}); | ||
const history = [ | ||
[ | ||
{ | ||
x: 10, | ||
y: 10, | ||
force: 0, | ||
type: TouchType.Start, | ||
id: 2, | ||
timestamp: 0, | ||
}, | ||
], | ||
[ | ||
{ | ||
x: 20, | ||
y: 20, | ||
force: 0, | ||
type: TouchType.Active, | ||
id: 2, | ||
timestamp: 1, | ||
}, | ||
], | ||
]; | ||
touchHandler(history); | ||
return null; | ||
}; | ||
|
||
const SimpleEndTouch = ({}: EmptyProps) => { | ||
const { useTouchHandler } = importSkia(); | ||
const touchHandler = useTouchHandler({ | ||
onStart: ({ x, y }) => { | ||
expect(x).toBe(10); | ||
expect(y).toBe(10); | ||
}, | ||
onActive: ({ x, y, velocityX, velocityY }) => { | ||
expect(x).toBe(20); | ||
expect(y).toBe(20); | ||
expect(velocityX).toBe(10); | ||
expect(velocityY).toBe(10); | ||
}, | ||
onEnd: ({ x, y, velocityX, velocityY }) => { | ||
expect(x).toBe(30); | ||
expect(y).toBe(30); | ||
expect(velocityX).toBe(10); | ||
expect(velocityY).toBe(10); | ||
}, | ||
}); | ||
const history = [ | ||
[ | ||
{ | ||
x: 10, | ||
y: 10, | ||
force: 0, | ||
type: TouchType.Start, | ||
id: 2, | ||
timestamp: 0, | ||
}, | ||
], | ||
[ | ||
{ | ||
x: 20, | ||
y: 20, | ||
force: 0, | ||
type: TouchType.Active, | ||
id: 2, | ||
timestamp: 1, | ||
}, | ||
], | ||
[ | ||
{ | ||
x: 30, | ||
y: 30, | ||
force: 0, | ||
type: TouchType.End, | ||
id: 2, | ||
timestamp: 2, | ||
}, | ||
], | ||
]; | ||
touchHandler(history); | ||
return null; | ||
}; | ||
|
||
describe("Test handling of touch information", () => { | ||
it("Should check that the received values are correct", () => { | ||
const { draw } = mountCanvas(<SimpleActiveTouch />); | ||
draw(); | ||
}); | ||
it("Calculates the velocity properly onEnd event", () => { | ||
const { draw } = mountCanvas(<SimpleEndTouch />); | ||
draw(); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a specific reason for upgrading Jest here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is so we can mark tests as expected failures.