Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine Skia core import in unit tests #803

Merged
merged 4 commits into from Aug 15, 2022
Merged

Refine Skia core import in unit tests #803

merged 4 commits into from Aug 15, 2022

Conversation

wcandillon
Copy link
Collaborator

since require returns any, this little helper function returns the proper type.

@wcandillon wcandillon self-assigned this Aug 14, 2022
chrfalch
chrfalch approved these changes Aug 15, 2022
View reviewed changes
Copy link
Collaborator

@chrfalch chrfalch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one :)

@wcandillon wcandillon merged commit 565fcdf into main Aug 15, 2022
@chrfalch chrfalch deleted the refineDynamicImports branch August 15, 2022 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrfalch chrfalch chrfalch approved these changes

Assignees

@wcandillon wcandillon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wcandillon @chrfalch