Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 3.3.0-preview3-pshopify1 #33

Closed
wants to merge 1 commit into from

Conversation

k0kubun
Copy link
Member

@k0kubun k0kubun commented Nov 28, 2023

This patch backports only bugfixes (and a few other relevant changes to avoid conflicts) on top of Ruby 3.3.0-preview3 so that we can deploy it to Core and (non-canary) SFR.

Diff: ruby/ruby@v3_3_0_preview3...Shopify:v3.3.0-preview3-pshopify1

@k0kubun
Copy link
Member Author

k0kubun commented Nov 28, 2023

I'll try running Core CI with this revision too.

@k0kubun
Copy link
Member Author

k0kubun commented Nov 28, 2023

It looks like now we want to run Ruby master (newer than 3.3.0-preview3) in production and 3.3.0-preview3 (without patches) in development, so I'm going to close this for now.

@k0kubun k0kubun closed this Nov 28, 2023
@casperisfine
Copy link
Contributor

I think we should make a "3.3.0-preview3-pshopify1", but just point it at a recent master commit. We merged way too many bug fixes in the last couple weeks to make backporting viable.

@k0kubun
Copy link
Member Author

k0kubun commented Nov 28, 2023

Yeah, I was thinking of it too. When we need yet another bump to a random Ruby master, so be it (in pshopify2). But by deploying the current Ruby master that way, we also reserve an option to only backport a few patches to that pshopify1 when creating pshopify2, which might help the stability of production after the first upgrade.

Do we actually want to take that path then?

@casperisfine
Copy link
Contributor

Do we actually want to take that path then?

Yeah, but after we have validated ome ref in production. That will allow us to "tag" that random ref and use the same in multiple apps more easily.

Anyway I expect the first beta/RCs in a couple weeks, so this isn't for long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants