Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes stdout leak in tests #242

Merged
merged 1 commit into from
Feb 4, 2024
Merged

Fixes stdout leak in tests #242

merged 1 commit into from
Feb 4, 2024

Conversation

gmcgibbon
Copy link
Member

Before

Run options: --seed 40302

# Running:

..........Rails server is not running. To get Rails features in the editor, boot the Rails server
...........................

Finished in 0.654810s, 56.5049 runs/s, 241.2914 assertions/s.

After

Run options: --seed 31481

# Running:

...............................

Finished in 0.664854s, 46.6268 runs/s, 206.0603 assertions/s.

@gmcgibbon gmcgibbon requested a review from a team as a code owner February 3, 2024 03:58
Copy link
Member

@st0012 st0012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@st0012 st0012 added chore Chore task and removed chore Chore task labels Feb 4, 2024
@st0012 st0012 merged commit 5d261ab into main Feb 4, 2024
54 checks passed
@st0012 st0012 deleted the fix_stdout_leak branch February 4, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants