Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Routes autocomplete #303

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

WIP: Routes autocomplete #303

wants to merge 15 commits into from

Conversation

andyw8
Copy link
Contributor

@andyw8 andyw8 commented Mar 25, 2024

I don't think there's any need to cache routes, since even on Core, withover 5000 routes, it takes only 1ms:

shopify(dev)> start=Time.now; Rails.application.routes.named_routes.helper_names.to_a; Time.now-start
=> 0.001078413

TODO:

@andyw8 andyw8 force-pushed the andyw8/update-for-ruby-lsp-refactor branch 3 times, most recently from 95be21c to 3b081ae Compare March 30, 2024 19:12
@andyw8 andyw8 force-pushed the andyw8/update-for-ruby-lsp-refactor branch from 3b081ae to c7b77d2 Compare March 30, 2024 19:31
@andyw8 andyw8 force-pushed the andyw8/routes-autocomplete branch 2 times, most recently from 5a01f7f to 3b2ccec Compare March 31, 2024 17:47
@andyw8 andyw8 force-pushed the andyw8/update-for-ruby-lsp-refactor branch 3 times, most recently from 1182623 to 343a974 Compare April 2, 2024 21:27
Base automatically changed from andyw8/update-for-ruby-lsp-refactor to main April 3, 2024 14:29
@andyw8 andyw8 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant