Ensure output printed during boot doesn't break LSP when starting #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyw8
force-pushed
the
andyw8/prevent-output-during-boot-from-breaking-lsp
branch
from
532b09b
to
abbc8c4
Compare
andyw8
force-pushed
the
andyw8/prevent-output-during-boot-from-breaking-lsp
branch
from
abbc8c4
to
b881f0b
Compare
andyw8
force-pushed
the
andyw8/prevent-output-during-boot-from-breaking-lsp
branch
from
b881f0b
to
d1bd9d9
Compare
vinistock
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an app happens to print two "\r\n" in a sequence while booting this can cause problems, as we're expecting to have a "Content-Length:" header afterwards.
With this change, we will skip over it.
Closes #309, closes #305.