Fix singleton class nesting when inside top level reference #2471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
bugfix
|
Thank you so much for the quick turnaround!!! |
st0012
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes the bug reported in #2287 (comment)
We need to use our proper nesting resolution
actual_nestingto discover the correct place where we discovered a singleton class, just like we're doing for regular classes. Otherwise, we incorrectly insert a name prefixed with::in the index state, which we do not want.Implementation
Started using our
actual_nestingmethod to figure out the right nesting.Automated Tests
Added a test.