-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump rubocop from 1.44.1 to 1.45.1 #497
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3a25469
to
4fc0cbe
Compare
@dependabot recreate |
Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.44.1 to 1.45.1. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.44.1...v1.45.1) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
4fc0cbe
to
d8d0e30
Compare
f82a981
to
d5cab70
Compare
sambostock
approved these changes
Feb 13, 2023
Comment on lines
+3642
to
+3645
Style/RedundantHeredocDelimiterQuotes: | ||
Description: Checks for redundant heredoc delimiter quotes. | ||
Enabled: true | ||
VersionAdded: '1.45' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rafaelfranca This cop was pending, so I enabled it, as it seems safe enough. TL;DR:
# bad
<<~'HEREDOC'
no interpolation to avoid
HEREDOC
# good
<<~HEREDOC
no interpolation to avoid
HEREDOC
# good
<<~'HEREDOC'
#{quotes mean don't interpolate this}
HEREDOC
# good
<<~HEREDOC
#{interpolate("this")}
HEREDOC
rafaelfranca
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
config change
Changes the Rubocop config by enabling, disabling, or reconfiguring one or many cops
dependencies
Pull requests that update a dependency file
ruby
Pull requests that update Ruby code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps rubocop from 1.44.1 to 1.45.1.
Release notes
Sourced from rubocop's releases.
... (truncated)
Changelog
Sourced from rubocop's changelog.
Commits
b0f8575
Cut 1.45.1c3f9516
Update Changelogc4ee09c
Fix an error forStyle/AccessModifierDeclarations
when if a non method defi...2404946
CI against JRuby 9.4 instead of JRuby 9.32989584
Fix a false positive forLint/Debugger
when methods containing different me...cdfc397
Restore a pending test for processing a regex with regoptdca9221
[Fix #11554] Fix an error forStyle/RedundantCondition
4ec3822
[Fix #11549] Fix an error for third party copsb1b393a
Switch back the docs version170d244
Cut 1.45Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)