String#slice! should clear the coderange when truncating

[Bug #19739] This bug was incidentally fixed in Ruby 3.2 via b0b9f72 but remains on 3.1 and older.
Shopify · Jun 21, 2023 · 3b351ee · 3b351ee
1 parent 504f37a
commit 3b351ee
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/string.c b/string.c
@@ -5435,6 +5435,7 @@ rb_str_slice_bang(int argc, VALUE *argv, VALUE str)
 	    slen -= len;
 	    STR_SET_LEN(str, slen);
 	    TERM_FILL(&sptr[slen], TERM_LEN(str));
+	    ENC_CODERANGE_CLEAR(str);
 	}
     }
     return result;

diff --git a/test/ruby/test_string.rb b/test/ruby/test_string.rb
@@ -3232,6 +3232,12 @@ def test_substr_code_range
     assert_not_predicate(data, :valid_encoding?)
     assert_predicate(data[100..-1], :valid_encoding?)
   end
+
+  def test_slice_bang_code_range
+    str = "[Bug #19739] ABC OÜ"
+    str.slice!(/ oü$/i)
+    assert_predicate str, :ascii_only?
+  end
 end
 
 class TestString2 < TestString