Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude X0 (C_RET_REG) from allocatable registers on arm #319

Merged
merged 2 commits into from Jul 14, 2022
Merged

Exclude X0 (C_RET_REG) from allocatable registers on arm #319

merged 2 commits into from Jul 14, 2022

Conversation

maximecb
Copy link

No description provided.

@maximecb maximecb requested a review from kddnewton July 14, 2022 18:06
@kddnewton
Copy link

One thing I was thinking though is that we're losing a bit of safety here by saying take_reg and dealloc_reg never care if they find the register that is given to them. I think that's kind of necessary for dealloc_reg since we don't know where it's going to be deallocated, but for take_reg we could have another function that's like... maybe_take_reg that we only call when we're forcing a specific register.

@maximecb
Copy link
Author

One thing I was thinking though is that we're losing a bit of safety here by saying take_reg and dealloc_reg never care if they find the register that is given to them. I think that's kind of necessary for dealloc_reg since we don't know where it's going to be deallocated, but for take_reg we could have another function that's like... maybe_take_reg that we only call when we're forcing a specific register.

Not a bad idea.

@maximecb maximecb merged commit f57fac9 into yjit_backend_ir Jul 14, 2022
@maximecb maximecb deleted the yjit_arm_ret_reg branch July 14, 2022 18:53
maximecb added a commit that referenced this pull request Jul 20, 2022
@maximecb
Exclude X0 (C_RET_REG) from allocatable registers on arm (#319)
4cc1a51 
* Exclude X0 (C_RET_REG) from allocatable registers on arm

* Add another small test snippett
maximecb added a commit that referenced this pull request Jul 25, 2022
@maximecb
Exclude X0 (C_RET_REG) from allocatable registers on arm (#319)
db73ca8 
* Exclude X0 (C_RET_REG) from allocatable registers on arm

* Add another small test snippett
noahgibbs pushed a commit that referenced this pull request Aug 23, 2022
@maximecb @noahgibbs
Exclude X0 (C_RET_REG) from allocatable registers on arm (#319)
dd03e72 
* Exclude X0 (C_RET_REG) from allocatable registers on arm

* Add another small test snippett
noahgibbs pushed a commit that referenced this pull request Aug 24, 2022
@maximecb @noahgibbs
Exclude X0 (C_RET_REG) from allocatable registers on arm (#319)
43c3e01 
* Exclude X0 (C_RET_REG) from allocatable registers on arm

* Add another small test snippett

PR: #319
noahgibbs pushed a commit that referenced this pull request Aug 25, 2022
@maximecb @noahgibbs
Exclude X0 (C_RET_REG) from allocatable registers on arm (#319)
bd86b9e 
* Exclude X0 (C_RET_REG) from allocatable registers on arm

* Add another small test snippett

PR: #319
k0kubun pushed a commit that referenced this pull request Aug 25, 2022
@maximecb @k0kubun
Exclude X0 (C_RET_REG) from allocatable registers on arm (#319)
aa13a05 
* Exclude X0 (C_RET_REG) from allocatable registers on arm

* Add another small test snippett

PR: #319
k0kubun pushed a commit that referenced this pull request Aug 25, 2022
@maximecb @k0kubun
Exclude X0 (C_RET_REG) from allocatable registers on arm (#319)
d023666 
* Exclude X0 (C_RET_REG) from allocatable registers on arm

* Add another small test snippett
k0kubun pushed a commit that referenced this pull request Aug 25, 2022
@maximecb @k0kubun
Exclude X0 (C_RET_REG) from allocatable registers on arm (#319)
9267b9c 
* Exclude X0 (C_RET_REG) from allocatable registers on arm

* Add another small test snippett
k0kubun pushed a commit that referenced this pull request Aug 25, 2022
@maximecb @k0kubun
Exclude X0 (C_RET_REG) from allocatable registers on arm (#319)
e58e50a 
* Exclude X0 (C_RET_REG) from allocatable registers on arm

* Add another small test snippett
k0kubun pushed a commit that referenced this pull request Aug 25, 2022
@maximecb @k0kubun
Exclude X0 (C_RET_REG) from allocatable registers on arm (#319)
3254d53 
* Exclude X0 (C_RET_REG) from allocatable registers on arm

* Add another small test snippett
@k0kubun k0kubun mentioned this pull request Aug 25, 2022
Closed
11 tasks
k0kubun pushed a commit that referenced this pull request Aug 26, 2022
@maximecb @k0kubun
Exclude X0 (C_RET_REG) from allocatable registers on arm (#319)
8e88131 
* Exclude X0 (C_RET_REG) from allocatable registers on arm

* Add another small test snippett
noahgibbs pushed a commit that referenced this pull request Aug 26, 2022
@maximecb @noahgibbs
Exclude X0 (C_RET_REG) from allocatable registers on arm (#319)
e4760f7 
* Exclude X0 (C_RET_REG) from allocatable registers on arm

* Add another small test snippett
k0kubun pushed a commit that referenced this pull request Aug 26, 2022
@maximecb @k0kubun
Exclude X0 (C_RET_REG) from allocatable registers on arm (#319)
b6d0e8b 
* Exclude X0 (C_RET_REG) from allocatable registers on arm

* Add another small test snippett
k0kubun pushed a commit that referenced this pull request Aug 29, 2022
@maximecb @k0kubun
Exclude X0 (C_RET_REG) from allocatable registers on arm (#319)
65c64da 
* Exclude X0 (C_RET_REG) from allocatable registers on arm

* Add another small test snippett
k0kubun pushed a commit that referenced this pull request Aug 29, 2022
@maximecb @k0kubun
Exclude X0 (C_RET_REG) from allocatable registers on arm (#319)
5e83419 
* Exclude X0 (C_RET_REG) from allocatable registers on arm

* Add another small test snippett
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kddnewton kddnewton Awaiting requested review from kddnewton

@XrXr XrXr Awaiting requested review from XrXr XrXr is a code owner

@tenderlove tenderlove Awaiting requested review from tenderlove

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maximecb @kddnewton