Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A lot of fixes coming from our pairing session #329

Merged
merged 7 commits into from Jul 19, 2022
Merged

A lot of fixes coming from our pairing session #329

merged 7 commits into from Jul 19, 2022

Conversation

kddnewton
Copy link

@kddnewton kddnewton commented Jul 19, 2022 •
edited

  • Previously we weren't properly handling if you were MOV-ing to/from SP. Now we detect that and switch to an ADD because otherwise MOV interprets it as the zero register.
  • Now we're using that to implement Op::FrameSetup and Op::FrameTeardown instead of the more esoteric adds.
  • The load and store module have been merged because their encoding was very similar.
  • I've added support for encoding both LDR and STR with pre and post indexing.
  • With these new encodings we can simplify our pushes and pops.

Our push goes from

SUB SP, SP, 16
STUR XT, [SP, 0]

to

STR XT, [SP, -16]!

and our pop goes from

LDUR XT, [SP, 0]
ADD SP, SP, 16

to

LDR XT, [SP], 16

@maximecb maximecb merged commit 8eb7fab into Shopify:yjit_backend_ir Jul 19, 2022
maximecb pushed a commit that referenced this pull request Jul 20, 2022
@kddnewton @maximecb
A lot of fixes coming from our pairing session (#329)
65c1e93 
* Move to/from SP on AArch64

* Consolidate loads and stores

* Implement LDR post-index and LDR pre-index for AArch64

* Implement STR post-index and STR pre-index for AArch64

* Module entrypoints for LDR pre/post -index and STR pre/post -index

* Use STR (pre-index) and LDR (post-index) to implement push/pop

* Go back to using MOV for to/from SP
maximecb pushed a commit that referenced this pull request Jul 25, 2022
@kddnewton @maximecb
A lot of fixes coming from our pairing session (#329)
8e744d8 
* Move to/from SP on AArch64

* Consolidate loads and stores

* Implement LDR post-index and LDR pre-index for AArch64

* Implement STR post-index and STR pre-index for AArch64

* Module entrypoints for LDR pre/post -index and STR pre/post -index

* Use STR (pre-index) and LDR (post-index) to implement push/pop

* Go back to using MOV for to/from SP
noahgibbs pushed a commit that referenced this pull request Aug 23, 2022
@kddnewton @noahgibbs
A lot of fixes coming from our pairing session (#329)
12cfcbb 
* Move to/from SP on AArch64

* Consolidate loads and stores

* Implement LDR post-index and LDR pre-index for AArch64

* Implement STR post-index and STR pre-index for AArch64

* Module entrypoints for LDR pre/post -index and STR pre/post -index

* Use STR (pre-index) and LDR (post-index) to implement push/pop

* Go back to using MOV for to/from SP
noahgibbs pushed a commit that referenced this pull request Aug 24, 2022
@kddnewton @noahgibbs
A lot of fixes coming from our pairing session (#329)
71448ff 
* Move to/from SP on AArch64

* Consolidate loads and stores

* Implement LDR post-index and LDR pre-index for AArch64

* Implement STR post-index and STR pre-index for AArch64

* Module entrypoints for LDR pre/post -index and STR pre/post -index

* Use STR (pre-index) and LDR (post-index) to implement push/pop

* Go back to using MOV for to/from SP

PR: #329
noahgibbs pushed a commit that referenced this pull request Aug 25, 2022
@kddnewton @noahgibbs
A lot of fixes coming from our pairing session (#329)
aaaa458 
* Move to/from SP on AArch64

* Consolidate loads and stores

* Implement LDR post-index and LDR pre-index for AArch64

* Implement STR post-index and STR pre-index for AArch64

* Module entrypoints for LDR pre/post -index and STR pre/post -index

* Use STR (pre-index) and LDR (post-index) to implement push/pop

* Go back to using MOV for to/from SP

PR: #329
k0kubun pushed a commit that referenced this pull request Aug 25, 2022
@kddnewton @k0kubun
A lot of fixes coming from our pairing session (#329)
eb1cf83 
* Move to/from SP on AArch64

* Consolidate loads and stores

* Implement LDR post-index and LDR pre-index for AArch64

* Implement STR post-index and STR pre-index for AArch64

* Module entrypoints for LDR pre/post -index and STR pre/post -index

* Use STR (pre-index) and LDR (post-index) to implement push/pop

* Go back to using MOV for to/from SP

PR: #329
k0kubun pushed a commit that referenced this pull request Aug 25, 2022
@kddnewton @k0kubun
A lot of fixes coming from our pairing session (#329)
f800cb4 
* Move to/from SP on AArch64

* Consolidate loads and stores

* Implement LDR post-index and LDR pre-index for AArch64

* Implement STR post-index and STR pre-index for AArch64

* Module entrypoints for LDR pre/post -index and STR pre/post -index

* Use STR (pre-index) and LDR (post-index) to implement push/pop

* Go back to using MOV for to/from SP
k0kubun pushed a commit that referenced this pull request Aug 25, 2022
@kddnewton @k0kubun
A lot of fixes coming from our pairing session (#329)
ac3cb3c 
* Move to/from SP on AArch64

* Consolidate loads and stores

* Implement LDR post-index and LDR pre-index for AArch64

* Implement STR post-index and STR pre-index for AArch64

* Module entrypoints for LDR pre/post -index and STR pre/post -index

* Use STR (pre-index) and LDR (post-index) to implement push/pop

* Go back to using MOV for to/from SP
k0kubun pushed a commit that referenced this pull request Aug 25, 2022
@kddnewton @k0kubun
A lot of fixes coming from our pairing session (#329)
f2e067b 
* Move to/from SP on AArch64

* Consolidate loads and stores

* Implement LDR post-index and LDR pre-index for AArch64

* Implement STR post-index and STR pre-index for AArch64

* Module entrypoints for LDR pre/post -index and STR pre/post -index

* Use STR (pre-index) and LDR (post-index) to implement push/pop

* Go back to using MOV for to/from SP
k0kubun pushed a commit that referenced this pull request Aug 25, 2022
@kddnewton @k0kubun
A lot of fixes coming from our pairing session (#329)
07ea313 
* Move to/from SP on AArch64

* Consolidate loads and stores

* Implement LDR post-index and LDR pre-index for AArch64

* Implement STR post-index and STR pre-index for AArch64

* Module entrypoints for LDR pre/post -index and STR pre/post -index

* Use STR (pre-index) and LDR (post-index) to implement push/pop

* Go back to using MOV for to/from SP
k0kubun pushed a commit that referenced this pull request Aug 26, 2022
@kddnewton @k0kubun
A lot of fixes coming from our pairing session (#329)
3e223cc 
* Move to/from SP on AArch64

* Consolidate loads and stores

* Implement LDR post-index and LDR pre-index for AArch64

* Implement STR post-index and STR pre-index for AArch64

* Module entrypoints for LDR pre/post -index and STR pre/post -index

* Use STR (pre-index) and LDR (post-index) to implement push/pop

* Go back to using MOV for to/from SP
noahgibbs pushed a commit that referenced this pull request Aug 26, 2022
@kddnewton @noahgibbs
A lot of fixes coming from our pairing session (#329)
3e64a55 
* Move to/from SP on AArch64

* Consolidate loads and stores

* Implement LDR post-index and LDR pre-index for AArch64

* Implement STR post-index and STR pre-index for AArch64

* Module entrypoints for LDR pre/post -index and STR pre/post -index

* Use STR (pre-index) and LDR (post-index) to implement push/pop

* Go back to using MOV for to/from SP
k0kubun pushed a commit that referenced this pull request Aug 26, 2022
@kddnewton @k0kubun
A lot of fixes coming from our pairing session (#329)
e8d04a9 
* Move to/from SP on AArch64

* Consolidate loads and stores

* Implement LDR post-index and LDR pre-index for AArch64

* Implement STR post-index and STR pre-index for AArch64

* Module entrypoints for LDR pre/post -index and STR pre/post -index

* Use STR (pre-index) and LDR (post-index) to implement push/pop

* Go back to using MOV for to/from SP
k0kubun pushed a commit that referenced this pull request Aug 29, 2022
@kddnewton @k0kubun
A lot of fixes coming from our pairing session (#329)
6ee6179 
* Move to/from SP on AArch64

* Consolidate loads and stores

* Implement LDR post-index and LDR pre-index for AArch64

* Implement STR post-index and STR pre-index for AArch64

* Module entrypoints for LDR pre/post -index and STR pre/post -index

* Use STR (pre-index) and LDR (post-index) to implement push/pop

* Go back to using MOV for to/from SP
k0kubun pushed a commit that referenced this pull request Aug 29, 2022
@kddnewton @k0kubun
A lot of fixes coming from our pairing session (#329)
4ae2c74 
* Move to/from SP on AArch64

* Consolidate loads and stores

* Implement LDR post-index and LDR pre-index for AArch64

* Implement STR post-index and STR pre-index for AArch64

* Module entrypoints for LDR pre/post -index and STR pre/post -index

* Use STR (pre-index) and LDR (post-index) to implement push/pop

* Go back to using MOV for to/from SP
@kddnewton kddnewton deleted the fixes branch November 3, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximecb maximecb Awaiting requested review from maximecb maximecb is a code owner

@XrXr XrXr Awaiting requested review from XrXr XrXr is a code owner

@tenderlove tenderlove Awaiting requested review from tenderlove

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kddnewton @maximecb