Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port gen_send_iseq to the new backend IR #381

Merged
merged 3 commits into from
Aug 9, 2022
Merged

Port gen_send_iseq to the new backend IR #381

merged 3 commits into from
Aug 9, 2022

Conversation

k0kubun
Copy link
Member

@k0kubun k0kubun commented Aug 9, 2022

No description provided.

@k0kubun k0kubun force-pushed the yjit-backend-send-iseq branch 2 times, most recently from 08dab53 to 5f9c660 Compare August 9, 2022 00:17
@k0kubun k0kubun marked this pull request as ready for review August 9, 2022 00:17
noahgibbs
noahgibbs reviewed Aug 9, 2022
View reviewed changes
yjit/src/codegen.rs Outdated Show resolved Hide resolved
@noahgibbs
Copy link

In general, looks really good. The only problems I'm seeing are from before your change :-)

(And they're minor.)

@kddnewton
Copy link

Code looks good. Can you change the asm.mov invocations to use asm.store when you're using a memory operand as the destination though? I'm on a mission to remove that encoding since I worry it'll be confusing in the future.

@maximecb maximecb enabled auto-merge (squash) August 9, 2022 15:59
@maximecb maximecb merged commit ca3f134 into yjit_backend_ir Aug 9, 2022
@maximecb maximecb deleted the yjit-backend-send-iseq branch August 9, 2022 16:16
@k0kubun k0kubun mentioned this pull request Aug 9, 2022
Merged
@k0kubun
Copy link
Member Author

k0kubun commented Aug 9, 2022

Code looks good. Can you change the asm.mov invocations to use asm.store when you're using a memory operand as the destination though? I'm on a mission to remove that encoding since I worry it'll be confusing in the future.

sure, filed #385

noahgibbs pushed a commit that referenced this pull request Aug 24, 2022
@k0kubun @maximecb @noahgibbs
Port gen_send_iseq to the new backend IR (#381)
d7016b5 
* Port gen_send_iseq to the new backend IR

* Replace occurrences of 8 by SIZEOF_VALUE

Co-authored-by: Maxime Chevalier-Boisvert <maximechevalierb@gmail.com>
Co-authored-by: Maxime Chevalier-Boisvert <maxime.chevalierboisvert@shopify.com>
noahgibbs pushed a commit that referenced this pull request Aug 24, 2022
@k0kubun @noahgibbs
Port gen_send_iseq to the new backend IR (#381)
e8d56c7 
* Port gen_send_iseq to the new backend IR

* Replace occurrences of 8 by SIZEOF_VALUE

Co-authored-by: Maxime Chevalier-Boisvert <maximechevalierb@gmail.com>
Co-authored-by: Maxime Chevalier-Boisvert <maxime.chevalierboisvert@shopify.com>

PR: #381
noahgibbs pushed a commit that referenced this pull request Aug 24, 2022
@k0kubun @noahgibbs
Port gen_send_iseq to the new backend IR (#381)
dc288ca 
* Port gen_send_iseq to the new backend IR

* Replace occurrences of 8 by SIZEOF_VALUE

Co-authored-by: Maxime Chevalier-Boisvert <maximechevalierb@gmail.com>
Co-authored-by: Maxime Chevalier-Boisvert <maxime.chevalierboisvert@shopify.com>

PR: #381
noahgibbs pushed a commit that referenced this pull request Aug 25, 2022
@k0kubun @noahgibbs
Port gen_send_iseq to the new backend IR (#381)
8a154f2 
* Port gen_send_iseq to the new backend IR

* Replace occurrences of 8 by SIZEOF_VALUE

Co-authored-by: Maxime Chevalier-Boisvert <maximechevalierb@gmail.com>
Co-authored-by: Maxime Chevalier-Boisvert <maxime.chevalierboisvert@shopify.com>

PR: #381
noahgibbs pushed a commit that referenced this pull request Aug 25, 2022
@k0kubun @noahgibbs
Port gen_send_iseq to the new backend IR (#381)
51a7615 
* Port gen_send_iseq to the new backend IR

* Replace occurrences of 8 by SIZEOF_VALUE

Co-authored-by: Maxime Chevalier-Boisvert <maximechevalierb@gmail.com>
Co-authored-by: Maxime Chevalier-Boisvert <maxime.chevalierboisvert@shopify.com>

PR: #381
noahgibbs pushed a commit that referenced this pull request Aug 25, 2022
@k0kubun @noahgibbs
Port gen_send_iseq to the new backend IR (#381)
c388a67 
* Port gen_send_iseq to the new backend IR

* Replace occurrences of 8 by SIZEOF_VALUE

Co-authored-by: Maxime Chevalier-Boisvert <maximechevalierb@gmail.com>
Co-authored-by: Maxime Chevalier-Boisvert <maxime.chevalierboisvert@shopify.com>

PR: #381
noahgibbs pushed a commit that referenced this pull request Aug 25, 2022
@k0kubun @noahgibbs
Port gen_send_iseq to the new backend IR (#381)
4360bf0 
* Port gen_send_iseq to the new backend IR

* Replace occurrences of 8 by SIZEOF_VALUE

Co-authored-by: Maxime Chevalier-Boisvert <maximechevalierb@gmail.com>
Co-authored-by: Maxime Chevalier-Boisvert <maxime.chevalierboisvert@shopify.com>

PR: #381
k0kubun added a commit that referenced this pull request Aug 25, 2022
@k0kubun
Port gen_send_iseq to the new backend IR (#381)
eebae07 
* Port gen_send_iseq to the new backend IR

* Replace occurrences of 8 by SIZEOF_VALUE

Co-authored-by: Maxime Chevalier-Boisvert <maximechevalierb@gmail.com>
Co-authored-by: Maxime Chevalier-Boisvert <maxime.chevalierboisvert@shopify.com>

PR: #381
k0kubun added a commit that referenced this pull request Aug 25, 2022
@k0kubun @maximecb
Port gen_send_iseq to the new backend IR (#381)
643870f 
* Port gen_send_iseq to the new backend IR

* Replace occurrences of 8 by SIZEOF_VALUE

Co-authored-by: Maxime Chevalier-Boisvert <maximechevalierb@gmail.com>
Co-authored-by: Maxime Chevalier-Boisvert <maxime.chevalierboisvert@shopify.com>
k0kubun added a commit that referenced this pull request Aug 25, 2022
@k0kubun @maximecb
Port gen_send_iseq to the new backend IR (#381)
f8628e8 
* Port gen_send_iseq to the new backend IR

* Replace occurrences of 8 by SIZEOF_VALUE

Co-authored-by: Maxime Chevalier-Boisvert <maximechevalierb@gmail.com>
Co-authored-by: Maxime Chevalier-Boisvert <maxime.chevalierboisvert@shopify.com>
k0kubun added a commit that referenced this pull request Aug 25, 2022
@k0kubun @maximecb
Port gen_send_iseq to the new backend IR (#381)
09fea24 
* Port gen_send_iseq to the new backend IR

* Replace occurrences of 8 by SIZEOF_VALUE

Co-authored-by: Maxime Chevalier-Boisvert <maximechevalierb@gmail.com>
Co-authored-by: Maxime Chevalier-Boisvert <maxime.chevalierboisvert@shopify.com>
k0kubun added a commit that referenced this pull request Aug 25, 2022
@k0kubun @maximecb
Port gen_send_iseq to the new backend IR (#381)
bdaf2b9 
* Port gen_send_iseq to the new backend IR

* Replace occurrences of 8 by SIZEOF_VALUE

Co-authored-by: Maxime Chevalier-Boisvert <maximechevalierb@gmail.com>
Co-authored-by: Maxime Chevalier-Boisvert <maxime.chevalierboisvert@shopify.com>
@k0kubun k0kubun mentioned this pull request Aug 25, 2022
Closed
11 tasks
k0kubun added a commit that referenced this pull request Aug 26, 2022
@k0kubun @maximecb
Port gen_send_iseq to the new backend IR (#381)
1a0ba1c 
* Port gen_send_iseq to the new backend IR

* Replace occurrences of 8 by SIZEOF_VALUE

Co-authored-by: Maxime Chevalier-Boisvert <maximechevalierb@gmail.com>
Co-authored-by: Maxime Chevalier-Boisvert <maxime.chevalierboisvert@shopify.com>
noahgibbs pushed a commit that referenced this pull request Aug 26, 2022
@k0kubun @maximecb @noahgibbs
Port gen_send_iseq to the new backend IR (#381)
cd300dc 
* Port gen_send_iseq to the new backend IR

* Replace occurrences of 8 by SIZEOF_VALUE

Co-authored-by: Maxime Chevalier-Boisvert <maximechevalierb@gmail.com>
Co-authored-by: Maxime Chevalier-Boisvert <maxime.chevalierboisvert@shopify.com>
k0kubun added a commit that referenced this pull request Aug 26, 2022
@k0kubun @maximecb
Port gen_send_iseq to the new backend IR (#381)
4661a5c 
* Port gen_send_iseq to the new backend IR

* Replace occurrences of 8 by SIZEOF_VALUE

Co-authored-by: Maxime Chevalier-Boisvert <maximechevalierb@gmail.com>
Co-authored-by: Maxime Chevalier-Boisvert <maxime.chevalierboisvert@shopify.com>
k0kubun added a commit that referenced this pull request Aug 29, 2022
@k0kubun @maximecb
Port gen_send_iseq to the new backend IR (#381)
3f96272 
* Port gen_send_iseq to the new backend IR

* Replace occurrences of 8 by SIZEOF_VALUE

Co-authored-by: Maxime Chevalier-Boisvert <maximechevalierb@gmail.com>
Co-authored-by: Maxime Chevalier-Boisvert <maxime.chevalierboisvert@shopify.com>
k0kubun added a commit that referenced this pull request Aug 29, 2022
@k0kubun @maximecb
Port gen_send_iseq to the new backend IR (#381)
668b99b 
* Port gen_send_iseq to the new backend IR

* Replace occurrences of 8 by SIZEOF_VALUE

Co-authored-by: Maxime Chevalier-Boisvert <maximechevalierb@gmail.com>
Co-authored-by: Maxime Chevalier-Boisvert <maxime.chevalierboisvert@shopify.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noahgibbs noahgibbs noahgibbs approved these changes

@maximecb maximecb Awaiting requested review from maximecb maximecb is a code owner

@XrXr XrXr Awaiting requested review from XrXr XrXr is a code owner

@tenderlove tenderlove Awaiting requested review from tenderlove

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@k0kubun @noahgibbs @kddnewton @maximecb