Port cfunc lookup, plus simpler cfunc generators. #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This port does *not* create invalidation regions to ensure minimum invalidatable block sizes, and so it does not port the to_s generator.
noahgibbs
force-pushed
the
noah_cfunc_lookup
branch
from
fc97920
to
fb3e90b
Compare
noahgibbs
changed the title
noahgibbs
added a commit
that referenced
this pull request
Aug 25, 2022
This port does *not* create invalidation regions to ensure minimum invalidatable block sizes, and so it does not port the to_s generator. PR: #388
noahgibbs
added a commit
that referenced
this pull request
Aug 25, 2022
This port does *not* create invalidation regions to ensure minimum invalidatable block sizes, and so it does not port the to_s generator. PR: #388
noahgibbs
added a commit
that referenced
this pull request
Aug 25, 2022
This port does *not* create invalidation regions to ensure minimum invalidatable block sizes, and so it does not port the to_s generator. PR: #388
noahgibbs
added a commit
that referenced
this pull request
Aug 25, 2022
This port does *not* create invalidation regions to ensure minimum invalidatable block sizes, and so it does not port the to_s generator. PR: #388
k0kubun
pushed a commit
that referenced
this pull request
Aug 25, 2022
This port does *not* create invalidation regions to ensure minimum invalidatable block sizes, and so it does not port the to_s generator. PR: #388
k0kubun
pushed a commit
that referenced
this pull request
Aug 25, 2022
This port does *not* create invalidation regions to ensure minimum invalidatable block sizes, and so it does not port the to_s generator.
k0kubun
pushed a commit
that referenced
this pull request
Aug 25, 2022
This port does *not* create invalidation regions to ensure minimum invalidatable block sizes, and so it does not port the to_s generator.
k0kubun
pushed a commit
that referenced
this pull request
Aug 25, 2022
This port does *not* create invalidation regions to ensure minimum invalidatable block sizes, and so it does not port the to_s generator.
k0kubun
pushed a commit
that referenced
this pull request
Aug 25, 2022
This port does *not* create invalidation regions to ensure minimum invalidatable block sizes, and so it does not port the to_s generator.
k0kubun
pushed a commit
that referenced
this pull request
Aug 26, 2022
This port does *not* create invalidation regions to ensure minimum invalidatable block sizes, and so it does not port the to_s generator.
noahgibbs
added a commit
that referenced
this pull request
Aug 26, 2022
This port does *not* create invalidation regions to ensure minimum invalidatable block sizes, and so it does not port the to_s generator.
k0kubun
pushed a commit
that referenced
this pull request
Aug 26, 2022
This port does *not* create invalidation regions to ensure minimum invalidatable block sizes, and so it does not port the to_s generator.
k0kubun
pushed a commit
that referenced
this pull request
Aug 29, 2022
This port does *not* create invalidation regions to ensure minimum invalidatable block sizes, and so it does not port the to_s generator.
k0kubun
pushed a commit
that referenced
this pull request
Aug 29, 2022
This port does *not* create invalidation regions to ensure minimum invalidatable block sizes, and so it does not port the to_s generator.
maximecb
pushed a commit
that referenced
this pull request
Sep 14, 2022
…history file doesn't exist If history file didn't exist when irb was started, @loaded_history_mtime would be nil. However, if the history file didn't exist before, but it exists when saving history, that means the history file was modified, and we should handle it the same way as we handle the other case where the history file was modified. Fixes #388 ruby/irb@8d277aafcb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This port does not create invalidation regions to ensure minimum invalidatable block sizes, and so it does not port the to_s generator. It also does not port str_concat (yet) -- I'd like to port the head-of-master performance improvements at the same time, so that will be a separate PR. Also str_concat needs XOR.