Port jit_rb_str_concat to new backend, re-enable cfunc lookup #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know that the bundler test failures are from my code, but the Graviton errors probably are. I'll see if I can repro this on my M1. |
noahgibbs
force-pushed
the
noah_str_shovel_new_backend
branch
3 times, most recently
from
d49eb3b
to
910613a
Compare
noahgibbs
changed the title
noahgibbs
force-pushed
the
noah_str_shovel_new_backend
branch
from
910613a
to
f29485d
Compare
noahgibbs
changed the title
noahgibbs
force-pushed
the
noah_str_shovel_new_backend
branch
from
f29485d
to
83b366b
Compare
maximecb
approved these changes
Aug 15, 2022
noahgibbs
added a commit
that referenced
this pull request
Aug 25, 2022
noahgibbs
added a commit
that referenced
this pull request
Aug 25, 2022
noahgibbs
added a commit
that referenced
this pull request
Aug 25, 2022
noahgibbs
added a commit
that referenced
this pull request
Aug 25, 2022
k0kubun
pushed a commit
that referenced
this pull request
Aug 25, 2022
k0kubun
pushed a commit
that referenced
this pull request
Aug 25, 2022
k0kubun
pushed a commit
that referenced
this pull request
Aug 25, 2022
k0kubun
pushed a commit
that referenced
this pull request
Aug 25, 2022
k0kubun
pushed a commit
that referenced
this pull request
Aug 25, 2022
11 tasks
k0kubun
pushed a commit
that referenced
this pull request
Aug 26, 2022
noahgibbs
added a commit
that referenced
this pull request
Aug 26, 2022
noahgibbs
added a commit
that referenced
this pull request
Aug 26, 2022
k0kubun
pushed a commit
that referenced
this pull request
Aug 26, 2022
k0kubun
pushed a commit
that referenced
this pull request
Aug 29, 2022
k0kubun
pushed a commit
that referenced
this pull request
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thought I had re-enabled cfunc lookup before. Maybe I didn't check it in? :-/
I think the remaining test failures aren't caused by this PR since it's parallel-bundler.