New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize bitmask immediates #403
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure! It's public domain code, but we might want to mention https://dougallj.wordpress.com/2021/10/30/bit-twiddling-optimising-aarch64-logical-immediate-encoding-and-decoding/ in the code though.
Also we should maybe test this more with a lookup table and such? Even though dougallj's version has have more eyes on it somethings might've gotten lost in translation.
Ehh he pretty explicitly says no need to mention. I suppose I can put a comment in though. We could add a lookup table, but I feel pretty confident with the existing test suite. I'll poke around a bit more though just to be super safe. I'll see if I can run it through https://gist.github.com/dinfuehr/51a01ac58c0b23e4de9aac313ed6a06a. |
659bad7
to
772efde
Compare
Also the full version has some comments which we could copy over: https://gist.github.com/dougallj/97d8621d4542ba31e004acc8075fac14 Another testing idea for |
Okay I just tested every possible value.
|
No description provided.