Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporarily disable rb_str_concat, add CI tests #407

Merged
merged 2 commits into from Aug 16, 2022
Merged

Temporarily disable rb_str_concat, add CI tests #407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47d8f7f
Temporarily disable rb_str_concat, add CI tests
maximecb Aug 16, 2022
ae85410
Source cargo env in cirrus test workflow
maximecb Aug 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion .cirrus.yml
View file
Open in desktop
Expand Up @@ -169,4 +169,7 @@ yjit_task:
# Check that we can build rdoc successfully
make_rdoc_script: source $HOME/.cargo/env && make -j rdoc

# TODO: check that we can we run test-all successfully
# Run John's YJIT instruction tests, and make sure we can load the test-all runner
test_yjit_script: source $HOME/.cargo/env && make test-all TESTS='test/ruby/test_yjit.rb' RUN_OPTS="--yjit-call-threshold=1"

# TODO: check that we can we run all of test-all successfully
5 changes: 4 additions & 1 deletion .github/workflows/yjit-new-backend.yml
View file
Open in desktop
Expand Up @@ -96,4 +96,7 @@ jobs:
# Check that we can build rdoc successfully
- run: make -j rdoc

# TODO: check that we can we run test-all successfully
# Run John's YJIT instruction tests, and make sure we can load the test-all runner
- run: make test-all TESTS='test/ruby/test_yjit.rb' RUN_OPTS="--yjit-call-threshold=1"

# TODO: check that we can we run all of test-all successfully
2 changes: 1 addition & 1 deletion yjit/src/codegen.rs
View file
Open in desktop
Expand Up @@ -6134,7 +6134,7 @@ impl CodegenGlobals {
//self.yjit_reg_method(rb_cString, "to_s", jit_rb_str_to_s);
//self.yjit_reg_method(rb_cString, "to_str", jit_rb_str_to_s);
self.yjit_reg_method(rb_cString, "bytesize", jit_rb_str_bytesize);
self.yjit_reg_method(rb_cString, "<<", jit_rb_str_concat);
//self.yjit_reg_method(rb_cString, "<<", jit_rb_str_concat);
//self.yjit_reg_method(rb_cString, "+@", jit_rb_str_uplus);

// Thread.current
Expand Down