Skip to content

Commit

Permalink
Merge pull request #656 from Shopify/add-2020-01-release
Browse files Browse the repository at this point in the history
Release 2020-01 REST ADMIN API VERSION
  • Loading branch information
ignacio-chiazzo committed Dec 23, 2019
2 parents b458fb9 + 47ea7ed commit 2a930d0
Show file tree
Hide file tree
Showing 4 changed files with 47 additions and 28 deletions.
11 changes: 6 additions & 5 deletions test/api_version_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -22,15 +22,15 @@ class ApiVersionTest < Test::Unit::TestCase
test "find_version removes unverified versions from version set if mode is set to :raise_on_unknown" do
ShopifyAPI::ApiVersion.version_lookup_mode = :define_on_unknown
assert ShopifyAPI::ApiVersion.versions.values.all?(&:verified?)
assert_equal 5, ShopifyAPI::ApiVersion.versions.size
assert_equal 6, ShopifyAPI::ApiVersion.versions.size

ShopifyAPI::ApiVersion.find_version('2019-30')
refute ShopifyAPI::ApiVersion.versions.values.all?(&:verified?)
assert_equal 6, ShopifyAPI::ApiVersion.versions.size
assert_equal 7, ShopifyAPI::ApiVersion.versions.size
ShopifyAPI::ApiVersion.version_lookup_mode = :raise_on_unknown

assert ShopifyAPI::ApiVersion.versions.values.all?(&:verified?)
assert_equal 5, ShopifyAPI::ApiVersion.versions.size
assert_equal 6, ShopifyAPI::ApiVersion.versions.size
end

test "find_version does not raise when coercing a string if no versions are defined when version_lookup_mode is :define_on_unknown" do
Expand Down Expand Up @@ -101,8 +101,9 @@ class ApiVersionTest < Test::Unit::TestCase
{
"2019-01" => ShopifyAPI::ApiVersion.new(handle: '2019-01', supported: true, latest_supported: false),
"2019-04" => ShopifyAPI::ApiVersion.new(handle: '2019-04', supported: true, latest_supported: false),
"2019-07" => ShopifyAPI::ApiVersion.new(handle: '2019-07', supported: true, latest_supported: true),
"2019-07" => ShopifyAPI::ApiVersion.new(handle: '2019-07', supported: true, latest_supported: false),
"2019-10" => ShopifyAPI::ApiVersion.new(handle: '2019-10', supported: false, latest_supported: false),
"2020-01" => ShopifyAPI::ApiVersion.new(handle: '2020-01', supported: false, latest_supported: true),
"unstable" => ShopifyAPI::ApiVersion.new(handle: 'unstable', supported: false, latest_supported: false),
}
)
Expand All @@ -114,7 +115,7 @@ class ApiVersionTest < Test::Unit::TestCase
)

assert_equal(
ShopifyAPI::ApiVersion.new(handle: '2019-07'),
ShopifyAPI::ApiVersion.new(handle: '2020-01'),
ShopifyAPI::ApiVersion.latest_stable_version
)
end
Expand Down
26 changes: 16 additions & 10 deletions test/fixtures/api_versions.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,26 +7,32 @@
},
{
"handle": "2019-04",
"latest_supported": false,
"display_name": "2019-04",
"supported": true,
"latest_supported": false
"supported": true
},
{
"handle": "2019-07",
"display_name": "2019-07 (Latest)",
"supported": true,
"latest_supported": true
"latest_supported": false,
"display_name": "2019-07",
"supported": true
},
{
"handle": "2019-10",
"display_name": "2019-10 (Release candidate)",
"supported": false,
"latest_supported": false
"latest_supported": false,
"display_name": "2019-10",
"supported": true
},
{
"handle": "2020-01",
"latest_supported": true,
"display_name": "2020-01 (Latest)",
"supported": true
},
{
"handle": "unstable",
"latest_supported": false,
"display_name": "unstable",
"supported": false,
"latest_supported": false
"supported": false
}
]
14 changes: 10 additions & 4 deletions test/fixtures/apis.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,21 @@
},
{
"handle": "2019-07",
"latest_supported": true,
"display_name": "2019-07 (Latest)",
"latest_supported": false,
"display_name": "2019-07",
"supported": true
},
{
"handle": "2019-10",
"latest_supported": false,
"display_name": "2019-10 (Release candidate)",
"supported": false
"display_name": "2019-10",
"supported": true
},
{
"handle": "2020-01",
"latest_supported": true,
"display_name": "2020-01 (Latest)",
"supported": true
},
{
"handle": "unstable",
Expand Down
24 changes: 15 additions & 9 deletions test/meta_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -8,32 +8,38 @@ class ApiVersionTest < Test::Unit::TestCase
"handle": "2019-01",
"display_name": "2019-01",
"supported": true,
"latest_supported": false,
"latest_supported": false
},
{
"handle": "2019-04",
"latest_supported": false,
"display_name": "2019-04",
"supported": true,
"supported": true
},
{
"handle": "2019-07",
"latest_supported": true,
"display_name": "2019-07 (Latest)",
"supported": true,
"latest_supported": false,
"display_name": "2019-07",
"supported": true
},
{
"handle": "2019-10",
"latest_supported": false,
"display_name": "2019-10 (Release candidate)",
"supported": false,
"display_name": "2019-10",
"supported": true
},
{
"handle": "2020-01",
"latest_supported": true,
"display_name": "2020-01 (Latest)",
"supported": true
},
{
"handle": "unstable",
"latest_supported": false,
"display_name": "unstable",
"supported": false,
},
"supported": false
}
].to_json


Expand Down

0 comments on commit 2a930d0

Please sign in to comment.