Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2020-01 REST ADMIN API VERSION #656

Merged
merged 2 commits into from
Dec 23, 2019
Merged

Conversation

ignacio-chiazzo
Copy link
Member

Release 2020-01 REST Admin API.

Copy link
Contributor

@jtgrenz jtgrenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While perhaps not strictly necessary, it might be a good idea to update https://github.com/Shopify/shopify_api/blob/master/test/fixtures/api_versions.json just for consistency

Alternatively, we could update the gem's test setup to use :define_on_unknown instead and selectively the api version / meta tests to use :raise_on_unknown where necessary.

I can't remember if we set the default test setup this way as an extra check for gem maintainers to verify that the version-specific code they were adding was valid or if it was just an oversight in the transition from the old manually defined versions.

@ignacio-chiazzo ignacio-chiazzo merged commit 2a930d0 into master Dec 23, 2019
@ignacio-chiazzo ignacio-chiazzo temporarily deployed to rubygems December 23, 2019 18:09 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants