Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure on Zeitwerk 2.6.5 #1058

Closed
andyw8 opened this issue Nov 11, 2022 · 5 comments · Fixed by #1059 or #1169
Closed

Failure on Zeitwerk 2.6.5 #1058

andyw8 opened this issue Nov 11, 2022 · 5 comments · Fixed by #1059 or #1169

Comments

@andyw8
Copy link
Contributor

andyw8 commented Nov 11, 2022

bundle exec rake test:rest_wrappers

(...many failures...)

2454) Error:
Metafield202201Test#test_64:
Zeitwerk::SetupRequired: please, finish your configuration and call Zeitwerk::Loader#setup once all is ready
    /Users/andyw8/.gem/ruby/3.1.1/gems/zeitwerk-2.6.5/lib/zeitwerk/loader.rb:143:in `block in unload'
    /Users/andyw8/.gem/ruby/3.1.1/gems/zeitwerk-2.6.5/lib/zeitwerk/loader.rb:142:in `synchronize'
    /Users/andyw8/.gem/ruby/3.1.1/gems/zeitwerk-2.6.5/lib/zeitwerk/loader.rb:142:in `unload'
    /Users/andyw8/src/github.com/Shopify/shopify-api-ruby/lib/shopify_api/context.rb:83:in `load_rest_resources'
    /Users/andyw8/.gem/ruby/3.1.1/gems/sorbet-runtime-0.5.10438/lib/types/private/methods/call_validation.rb:157:in `bind_call'
    /Users/andyw8/.gem/ruby/3.1.1/gems/sorbet-runtime-0.5.10438/lib/types/private/methods/call_validation.rb:157:in `validate_call'
    /Users/andyw8/.gem/ruby/3.1.1/gems/sorbet-runtime-0.5.10438/lib/types/private/methods/call_validation.rb:89:in `block in create_validator_slow'
    /Users/andyw8/src/github.com/Shopify/shopify-api-ruby/lib/shopify_api/context.rb:77:in `setup'

Seems due to this:

Attempting to eager load or reload without previously invoking setup now raises Zeitwerk::SetupRequired.

https://github.com/fxn/zeitwerk/blob/main/CHANGELOG.md#265-6-november-2022

We do call loader.setup in lib/shopify_api.rb but something else must be needed.

FYI @klenotiw @nelsonwittwer

@andyw8
Copy link
Contributor Author

andyw8 commented Nov 16, 2022

Keeping this open since the underlying issue still needs addressed.

@andyw8 andyw8 reopened this Nov 16, 2022
@github-actions
Copy link

This issue is stale because it has been open for 60 days with no activity. It will be closed if no further action occurs in 14 days.

@github-actions github-actions bot added the Stale label Jan 16, 2023
@github-actions
Copy link

We are closing this issue because it has been inactive for a few months.
This probably means that it is not reproducible or it has been fixed in a newer version.
If it’s an enhancement and hasn’t been taken on since it was submitted, then it seems other issues have taken priority.

If you still encounter this issue with the latest stable version, please reopen using the issue template. You can also contribute directly by submitting a pull request– see the CONTRIBUTING.md file for guidelines

Thank you!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 31, 2023
@jaredbeck
Copy link

When will the constraint in the gemspec be lifted, please?

  s.add_runtime_dependency("zeitwerk", "~> 2.5", "< 2.6.5") # https://github.com/Shopify/shopify-api-ruby/issues/1058

It's preventing us from using new versions of zeitwerk.

@sterrym
Copy link
Contributor

sterrym commented Jun 6, 2023

👍 to @jaredbeck 's question. We are being prevented from using new versions of zeitwerk in other projects. Did the newer versions fix the above?

cc: @andyw8

@nelsonwittwer nelsonwittwer reopened this Jun 6, 2023
@github-actions github-actions bot removed the Stale label Jun 7, 2023
sterrym added a commit that referenced this issue Jun 7, 2023
* Unpin zeitwerk version from 2.6.5 - Fixes #1058
* Update CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants