Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpin zeitwerk version from 2.6.5 #1169

Merged
merged 2 commits into from
Jun 7, 2023
Merged

Unpin zeitwerk version from 2.6.5 #1169

merged 2 commits into from
Jun 7, 2023

Conversation

sterrym
Copy link
Contributor

@sterrym sterrym commented Jun 7, 2023

Description

Fixes #1058

Please, include a summary of what the PR is for:

  • Removes the pinning of zeitwerk to version 2.6.5

How has this been tested?

bundle exec rake test:rest_wrappers now runs with zeitwerk 2.6.5+

Checklist:

  • My commit message follow the pattern described in here
  • I have performed a self-review of my own code.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have updated the project documentation.
  • I have added a changelog line.

@sterrym sterrym force-pushed the sterrym/zeitwerk-unpin-version branch from 6dc7373 to 6f62667 Compare June 7, 2023 13:56
@sterrym sterrym marked this pull request as ready for review June 7, 2023 14:02
nelsonwittwer
nelsonwittwer approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@nelsonwittwer nelsonwittwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for you contribution!

@sterrym sterrym changed the title Unpinned zeitwerk version from 2.6.5 Unpin zeitwerk version from 2.6.5 Jun 7, 2023
@sterrym sterrym merged commit 9459158 into main Jun 7, 2023
8 checks passed
@sterrym sterrym deleted the sterrym/zeitwerk-unpin-version branch June 7, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nelsonwittwer nelsonwittwer nelsonwittwer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failure on Zeitwerk 2.6.5
2 participants
@sterrym @nelsonwittwer