Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong type definition for the profile_id attribute of the ShippingZone REST resource #1100

Closed
dhalai opened this issue Jan 13, 2023 · 3 comments
Assignees

Comments

@dhalai
Copy link

dhalai commented Jan 13, 2023

Issue summary

Starting from the shopify-api-ruby 10.0.0 if the REST API is used there is no way to get a profile_id attribute related to the particular ShippingZone resource.

  • shopify_api version: 10.0.0 and up

Expected behavior

The profile_id attribute of the ShippingZone REST resource should return a string (e.g. gid://shopify/DeliveryProfile/<profile_id>) or nil if there are no related profile.

It should work for all API versions.

Actual behavior

It returns the TypeError Exception

Steps to reproduce the problem

  1. Get an existing ShippingZone by using REST API
  2. Try to access its profile_id
@github-actions
Copy link

This issue is stale because it has been open for 60 days with no activity. It will be closed if no further action occurs in 14 days.

@github-actions github-actions bot added the Stale label Mar 15, 2023
@nelsonwittwer nelsonwittwer self-assigned this Mar 22, 2023
@nelsonwittwer
Copy link
Contributor

Thanks for your patience with this! I've tracked down the root problem and we are working on a fix! Unfortunately, the problem seems to be a type misunderstanding upstream with our API at Shopify so I'm not in complete control of the fix. I see this root issue affecting several other issues within our REST resources here which is a bummer :(

As a workaround, you could use the rest client directly directly, though you'll have to parse the response accordingly.

@nelsonwittwer
Copy link
Contributor

Fixed with #1137

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants