Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate resources for 2023_04 release #1137

Merged
merged 4 commits into from
Apr 11, 2023

Conversation

nelsonwittwer
Copy link
Contributor

@nelsonwittwer nelsonwittwer commented Apr 6, 2023

Description

  1. Adds 2023_04 API version clsoing A new release of the Shopify API is due soon #1132 / A new release of the Shopify API occurred #1135
  2. Generates REST resources for new API version
  3. Introduces a safer create_instance flow based off of new data structures returned from Core.
  4. Fixes several typing issues that were causing several REST resources to be unusable. These upstream fixes will address the follow issues:

How has this been tested?

  • Rest resource tests have been run.
  • Generated a new app with this topic branch. Was able to install app and make API call

Checklist:

  • My commit message follow the pattern described in here
  • I have performed a self-review of my own code.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have updated the project documentation.
  • I have added a changelog line.

Copy link
Contributor

@paulomarg paulomarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, skipping over the auto-generated stuff :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants