Fix ActiveSupport inflector dependency #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyw8
force-pushed
the
andyw8/fix-active-support-inflector-dependency
branch
from
6329aab
to
aca5cbe
Compare
nelsonwittwer
approved these changes
Nov 23, 2022
andyw8
force-pushed
the
andyw8/fix-active-support-inflector-dependency
branch
from
aca5cbe
to
7367d33
Compare
kaarelss
added a commit
to kaarelss/shopify-api-ruby
that referenced
this pull request
Nov 29, 2022
…y-api-ruby into response_in_error_object * 'response_in_error_object' of github.com:kaarelss/shopify-api-ruby: Added assertion that response is present in MaxHttpRetriesExceededError Added sorbet assertion Removed extra empty line ShopifyAPI::Clients::HttpResponse as argument for ShopifyAPI::Errors::HttpResponseError because code can be obtained from response as well as headers for custom retry logic Remove mentions of private apps (Shopify#1062) Fix ActiveSupport inflector dependency (Shopify#1063) Move Session Storage to `shopify_app` (Shopify#1055) Remove session argument from REST examples (Shopify#1064) Constrain Zeitwerk to 2.6.5 (Shopify#1059) Clarify statement about packages (Shopify#1057)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Attempting to call the API in a plain Ruby script fails since
active_support/inflectionis not available. It's listed as a development dependency, but it's used here:shopify-api-ruby/lib/shopify_api/rest/base.rb
Line 4 in 9ef0f17
I expect this is rarely a problem in real-world usage since most people will be using this with Rails, which already provides
active_support.How has this been tested?
Tested locally with a plain Ruby script.
Checklist:
I have added tests that prove my fix is effective or that my feature works.I have updated the project documentation.