Fix assigned fulfillment order parse error #1081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulomarg
force-pushed
the
fix_assigned_fulfillment_order_parse_error
branch
from
3456231
to
3d54c5d
Compare
mkevinosullivan
approved these changes
Jan 4, 2023
paulomarg
changed the base branch from
main
to
update_dependencies_and_rubocop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was a bug when parsing the JSON response for the
AssignedFulfillmentOrderREST resource, which usesfulfillment_orders. This path doesn't match the default behaviour (trying to match the class name), so we need to be able to override that behaviour for this resource in particular.This PR adds that override capability and updates the auto-generated REST resources.
Non-automatic changes are here: 241cfd8
How has this been tested?
dev sanity+bundle exec rake test:rest_wrappersChecklist: