Gracefully handle HTTP 204 response bodies #1098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
5 tasks
nelsonwittwer
approved these changes
Mar 21, 2023
|
@nelsonwittwer thank you for taking a look 🙌 |
nickmealey
pushed a commit
to heliumdevelopment/shopify-api-ruby
that referenced
this pull request
Jun 6, 2023
* Gracefully handle HTTP 204 response bodies * Add changelog entry for Shopify#1098 * Fix up changelog formatting * Rubocop fixup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1097
What is the problem it is solving?
The HTTP client raises a
NoMethodErrorwhen the server responds with a 204. I believe this is becauseHTTPartydoesn't bother to parse the response body in certain situations, and just suppliesnilas the response body instead.What is the context of these changes?
It's not entirely clear what this question is asking. Please refer to #1097 for more context.
What is the impact of this PR?
It allows people to use the library to do things like delete discount codes and price rules without raising an exception when Shopify responds with a 204, the expected response.
How has this been tested?
I wrote a test first to confirm it would trigger a failure, which it did (see screenshot). The failure went away with my fix.
I have used the patched fork of the gem to delete discount codes and price rules in a development environment, which it does without raising an exception.
Checklist: