Handle JSON::ParserError when http response is HTML and raise ShopifyAPI::Errors::HttpResponseError

[kaarelss]

Handle JSON::ParserError when response is HTML and pass response body to ShopifyAPI::Clients::HttpResponse because it accepts body also as string.

Description

Fixes #1091
Fixed #1107

Please, include a summary of what the PR is for:

• It is not possible to determine HTTP response code when response body is HTML and JSON::ParserError is thrown. So rescuing JSON::ParserError would raise ShopifyAPI::Errors::HttpResponseError and add response code.

How has this been tested?

All tests passed as well as new test is included for this new functionality:
test_json_parser_error in http_client_test.rb

Checklist:

• My commit message follow the pattern described in here
• I have performed a self-review of my own code.
• I have added tests that prove my fix is effective or that my feature works.
• I have updated the project documentation.
• I have added a changelog line.

[ClaytonPassmore]

Nice! I believe this would fix the following:

• REST client raises an exception on HTTP 204 response #1097
• JSON Parser Error raised with unexpected HTML response from Shopfiy #1107

[kaarelss]

Nice! I believe this would fix the following:

• REST client raises an exception on HTTP 204 response #1097
• JSON Parser Error raised with unexpected HTML response from Shopfiy #1107

Actually I added the nil? guard from your PR, but I guess it should be merged first, because you have a test created there. Thank you for mentioning #1107. Also added #1091

[vishals-vebuin]

@kaarelss is there any idea? how much time it will take to fix it?

[ClaytonPassmore]

@vishals-vebuin we're waiting on someone from Shopify to approve.

As far as I can tell, the last community PR they interacted with was from October 20th, 2022.

[ClaytonPassmore]

@kaarelss heads up that #1098 got merged, so you may need to update your branch 👍

[kaarelss]

@kaarelss heads up that #1098 got merged, so you may need to update your branch 👍

Thanks @ClaytonPassmore Will do.

[nelsonwittwer]

@kaarelss - Do you mind fixing that linting issue on your end, I tried doing it with GitHub's editor here but it added a trailing whitespace 🤕 Would love to get this out for our release here in the next day or two, thank you for your contributions! 🎉

[kaarelss]

@kaarelss - Do you mind fixing that linting issue on your end, I tried doing it with GitHub's editor here but it added a trailing whitespace 🤕 Would love to get this out for our release here in the next day or two, thank you for your contributions! 🎉

Done