Add api_host to ShopifyAPI::Context #1241
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RE: #1235
This PR adds new
api_host
"setting" toContext
. TheHttpClient
will useapi_host
when set, otherwise default to calling the API as specified by thesession.shop
value.Whilst this feels a little weird to add this value to
Context
, it seems to be way theShopifyAPI
gem is "configurable" by consumers.How has this been tested?
Unit tests in this project and using this branch in a service.
Checklist: