Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the shop.tax_shipping type #1320

Merged
merged 3 commits into from
May 15, 2024
Merged

Update the shop.tax_shipping type #1320

merged 3 commits into from
May 15, 2024

Conversation

lizkenyon
Copy link
Contributor

Description

Fixes #1271

The tax_shipping field will be null on newly created stores. true when enabled and false when subsequently disabled.

How has this been tested?

  • Tested in a development app

Checklist:

  • My commit message follow the pattern described in here
  • I have performed a self-review of my own code.
  • I have added a changelog line.

@lizkenyon
Update the shop.tax_shipping type
6f21465 
The valid values are null,true,false
@lizkenyon lizkenyon requested a review from a team as a code owner May 15, 2024 19:29
@lizkenyon lizkenyon merged commit a64f7dd into main May 15, 2024
9 checks passed
@lizkenyon lizkenyon deleted the liz/update-tax-shipping-type branch May 15, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulomarg paulomarg paulomarg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shop.tax_shipping wrong sorbet type
2 participants
@lizkenyon @paulomarg