Add access_scopes attribute to session object

[NabeelAhsen]

Related: Shopify/shopify_app#1192

This PR introduces an access_scopes attribute to the Session object.

Things to focus on

1. Do we determine the validity of a session through this attribute?
2. Is there immediate benefit in returning a ShopifyAPI::ApiAccess object? Will a string suffice?
3. Is this level of error handling needed?

[rezaansyed]

1. Do we determine the validity of a session through this attribute?
2. Is there immediate benefit in returning a ShopifyAPI::ApiAccess object? Will a string suffice?
3. Is this level of error handling needed?

1. Not sure what you mean here with this. But this is only a value object used to encompass the access token (and now access scopes)
2. ShopifyAPI::ApiAccess should be the preferred approach here. Anyone using this object has the ability to compare two objects for equality and subsets.
3. No. access_scopes should be nil if not specified.

[rezaansyed]

🎩 LGTM 👍🏼

[ragalie]

What does it raise?

[rezaansyed]

Currently it's NoMethodError because the strip method doesn't exist on the object passed in object passed in. I can specify NoMethodError

[rezaansyed]

Should we have a custom error for ApiAccess to throw when an invalid input is passed in?

[NabeelAhsen]

I think that because specifying api_access is opt-in, it's up to the user to specify good input. In this case, building a new session will either:

• parse access_scopes correctly or
• throw some error (automatically an invalid session)

For this test, we know that it's NoMethodError because strip doesn't exist on the hash, but really the bad input could throw anything.

[NabeelAhsen]

Thanks for addressing comments @rezaansyed!

[mkevinosullivan]

👍🏻