Deprecate unnecessary validate_shop call from JWT class #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulomarg
force-pushed
the
deprecate_unnecessary_validate_shop_method
branch
from
ebf2241
to
259ec46
Compare
andyw8
reviewed
Apr 25, 2022
paulomarg
force-pushed
the
deprecate_unnecessary_validate_shop_method
branch
3 times, most recently
from
f047d77
to
57b9a1a
Compare
mkevinosullivan
approved these changes
Apr 25, 2022
paulomarg
force-pushed
the
deprecate_unnecessary_validate_shop_method
branch
from
57b9a1a
to
57e4f98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
validate_shopfrom the JWT class is not really necessary, because this information is coming from Shopify, and it is signed, so we can trust that, if the data itself is valid, the shop name will be correct.How has this been tested?
Via tests.
Checklist: