Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 2022-07, remove 2021-07 REST Resources #987

Merged
merged 5 commits into from
Jul 4, 2022
Merged

Add 2022-07, remove 2021-07 REST Resources #987

merged 5 commits into from
Jul 4, 2022

Conversation

mkevinosullivan
Copy link
Contributor

WHY are these changes introduced?

To support the quarterly addition/deprecation of API versions.

Does the Ruby part of https://github.com/Shopify/first-party-library-planning/issues/372

WHAT is this pull request doing?

  • Adds REST resources for 2022-07
  • Removes REST resources for 2021-07

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added a changelog entry, prefixed by the type of change noted above
  • I have added/updated tests for this change
  • I have documented new APIs/updated the documentation for modified APIs (for public APIs)

@mkevinosullivan mkevinosullivan requested a review from a team as a code owner July 4, 2022 13:58
paulomarg
paulomarg approved these changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@paulomarg paulomarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkevinosullivan mkevinosullivan merged commit 30041cd into main Jul 4, 2022
@mkevinosullivan mkevinosullivan deleted the add_2022-07_remove_2021-07 branch July 4, 2022 14:59
@shopify-shipit shopify-shipit bot temporarily deployed to rubygems July 4, 2022 16:27 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulomarg paulomarg paulomarg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkevinosullivan @paulomarg