Don't delete sessions when handling 401 errors #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulomarg
approved these changes
May 9, 2024
packages/apps/shopify-app-remix/src/server/authenticate/admin/billing/cancel.ts
Outdated
Show resolved
Hide resolved
packages/apps/shopify-app-remix/src/server/authenticate/admin/strategies/token-exchange.ts
Outdated
Show resolved
Hide resolved
lizkenyon
reviewed
May 9, 2024
packages/apps/shopify-app-remix/src/server/authenticate/helpers/invalidate-session-token.ts
Outdated
Show resolved
Hide resolved
zzooeeyy
force-pushed
the
dont-delete-sessions
branch
from
86e6855
to
41c2a98
Compare
zzooeeyy
force-pushed
the
dont-delete-sessions
branch
from
41c2a98
to
1b1ef3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Addressing this comment
WHAT is this pull request doing?
When handling 401 errors, invalidate the access token instead of deleting the record
Tested to ensure behaviour is the same as before:
token-deleted.mp4
token-invalidated.mp4
Type of change
Checklist
yarn changesetto create a draft changelog entry (do NOT update theCHANGELOG.mdfiles manually)