Remove the use of cookies for shopOrigin
#493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannachen
changed the title
shopOriginshopOrigin
paulomarg
approved these changes
Dec 10, 2020
|
🎩 ed this by tweaking the CLI to check this branch out, I was able to create the app, run it and perform OAuth with no problems. LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Browsers are slowly dropping 3rd-party cookie support, so partners shouldn't use cookies as the method to store
shopOriginwhen building a new App Bridge app. Instead, developers should be getting the value ofshopfrom URL search parameters.Related to https://github.com/Shopify/app-bridge/issues/1742 https://github.com/Shopify/shopify-dev/pull/4643
WHAT is this pull request doing?
This PR removes boilerplate code using 3rd-party cookies and cookies-related packages. It also shows partners how to use Next.js to retrieve the
shopvalue from the server-side.Also, clean up some unused imports.