-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a simple page to list a few products from a GraphQL query. #27
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
import {Card, Layout, Page} from "@shopify/polaris"; | ||
import React from "react"; | ||
|
||
function PageLayout({children}) { | ||
return <Page> | ||
<Layout> | ||
<Layout.Section> | ||
<Card> | ||
{children} | ||
</Card> | ||
</Layout.Section> | ||
</Layout> | ||
</Page> | ||
} | ||
|
||
export default PageLayout; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
import {ResourceItem, ResourceList, TextStyle} from "@shopify/polaris"; | ||
import React from "react"; | ||
|
||
export function ProductsList({data}) { | ||
|
||
const products = data.products.edges.map((edge) => { | ||
return { | ||
id: edge.node.id, | ||
title: edge.node.title, | ||
}; | ||
}); | ||
return <ResourceList | ||
showHeader | ||
resourceName={{singular: 'product', plural: 'products'}} | ||
items={products} | ||
renderItem={({id, title}) => { | ||
|
||
return ( | ||
<ResourceItem | ||
id={id} | ||
accessibilityLabel={`View details for ${title}`} | ||
> | ||
<h3> | ||
<TextStyle variation="strong">{title}</TextStyle> | ||
</h3> | ||
</ResourceItem> | ||
); | ||
}} | ||
> | ||
</ResourceList> | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
import {gql, useQuery} from '@apollo/client'; | ||
import {Banner} from '@shopify/polaris'; | ||
import React from 'react'; | ||
import {ProductsList} from "./ProductsList"; | ||
import {Loading} from '@shopify/app-bridge-react'; | ||
|
||
const PRODUCTS_QUERY = gql`{ | ||
products(first: 10) { | ||
edges { | ||
cursor | ||
node { | ||
id, | ||
title, | ||
onlineStoreUrl | ||
} | ||
} | ||
} | ||
}`; | ||
|
||
|
||
function ProductsPage() { | ||
const {loading, error, data} = useQuery(PRODUCTS_QUERY); | ||
|
||
if (loading) return ( | ||
<Loading/> | ||
); | ||
|
||
if (error) return ( | ||
<Banner status="critical"> | ||
There was an issue loading products. | ||
</Banner> | ||
); | ||
|
||
return <ProductsList data={data}/>; | ||
} | ||
|
||
export default ProductsPage; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If simply passing along all the headers doesn't work, we could come up with a list of the ones we want to set and go over the list here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's a good idea, I wasn't sure though what would be those ones. I will check the issue with the headers separately. Thought of putting it aside given that we do not using it right now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed! Though we probably also want to make sure to forward the response code we got back!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, let me have those two points in a different PR