Add a simple page to list a few products from a GraphQL query. #27
Conversation
MuhammadFarag
force-pushed
the
sample-products-page
branch
from
1c1987e
to
b4e103f
Compare
resources/js/react/App.jsx
Outdated
| return ( | ||
| <h1>Hello React</h1> | ||
| <AppProvider i18n={translations}> |
There was a problem hiding this comment.
I think if you use <Provider> from app-bridge-react, you'll get the styling automatically so you don't have to directly include the CSS.
There was a problem hiding this comment.
I added <Provider> but I still had to include the css, this is being done in the node app as well
| @@ -112,7 +112,7 @@ | |||
|
|
|||
| Route::post('/graphql', function (Request $request) { | |||
| $result = Utils::graphqlProxy($request->header(), $request->cookie(), $request->getContent()); | |||
| return response($result->getDecodedBody())->withHeaders($result->getHeaders()); | |||
| return response($result->getDecodedBody()); | |||
There was a problem hiding this comment.
If simply passing along all the headers doesn't work, we could come up with a list of the ones we want to set and go over the list here.
There was a problem hiding this comment.
Yes, that's a good idea, I wasn't sure though what would be those ones. I will check the issue with the headers separately. Thought of putting it aside given that we do not using it right now.
There was a problem hiding this comment.
Agreed! Though we probably also want to make sure to forward the response code we got back!
There was a problem hiding this comment.
Good point, let me have those two points in a different PR
MuhammadFarag
force-pushed
the
sample-products-page
branch
2 times, most recently
from
9fcee09
to
3585f40
Compare
resources/js/react/App.jsx
Outdated
| const config = {apiKey: apiKey, shopOrigin: shop, host: host}; | ||
|
|
There was a problem hiding this comment.
Sorry, I failed to see this before, but the call to createApp below can also be replaced by const app = useAppBridge(); from app-bridge-react.
MuhammadFarag
force-pushed
the
sample-products-page
branch
from
3585f40
to
35fee18
Compare
MuhammadFarag
force-pushed
the
sample-products-page
branch
from
35fee18
to
8204174
Compare
MuhammadFarag
force-pushed
the
sample-products-page
branch
from
8204174
to
32edac0
Compare
WHY are these changes introduced?
Add a very simple page to list a few products from a GraphQL query, to demonstrate how to load a session / use it for requests.
WHAT is this pull request doing?
Checklist