[Fix] Revert "Add declarative webhooks and remove imperative" #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Related to Shopify/shopify-api-ruby#1328
This reverts commit 82b9d7a.
The template is not set up to handle declarative webhooks config yet. It's still relying on the convention of matching webhook topic with a job class after registering with a centralized manager.
https://github.com/Shopify/shopify_app/blob/b921685a0dbf1948905cd3057d35d2f484cdbce8/lib/shopify_app/managers/webhooks_manager.rb#L53
WHAT is this pull request doing?
Adds back webhook registrations for compliance topics and app/uninstalled
Test this PR
Run
shopify app devand preview the app in your test shopChecklist
Note: once this PR is merged, it becomes a new release for this template.
README.mdfile and other related documentation, if applicable