Skip to content
This repository has been archived by the owner on Dec 6, 2023. It is now read-only.

Integration test with graphql #50

Merged
merged 1 commit into from
Sep 3, 2021
Merged

Integration test with graphql #50

merged 1 commit into from
Sep 3, 2021

Conversation

vividviolet
Copy link
Member

@vividviolet vividviolet commented Aug 31, 2021

Tophat

  1. Run make bootstrap and verify that there are no errors
  2. Run make run serve < testdata/shopifile.yml
  3. Visit http://localhost:8000/extensions/00000000-0000-0000-0000-000000000000/assets/main.js and verify that the JS bundle loads

@vividviolet vividviolet changed the base branch from shipit to main August 31, 2021 13:50
@vividviolet vividviolet force-pushed the integration-graphql branch 4 times, most recently from 03021e0 to 69c88e5 Compare August 31, 2021 21:08
@t6d
Copy link
Contributor

t6d commented Sep 1, 2021

Are bootstrap and integration-test identical? If integration-test is really just an alias, you could do

.PHONY: integration-test
integration-test: bootstrap

This is make's way of specifying dependencies on other tasks.

@vividviolet
Copy link
Member Author

Currently they are not identical. Integration test sets up a single fake extension which makes use of all features supported by the node package (react, typescript, graphql) and just ensures the extension can be built.

I was intending bootstrap to set up real extensions we can use to test with the dev console without necessarily running all of these through CI.

@cecyc
Copy link
Contributor

cecyc commented Sep 2, 2021

I am getting a 404 when trying to tophat :(
Screen Shot 2021-09-02 at 3 18 58 PM

@vividviolet
Copy link
Member Author

@cecyc Sorry, this branch is out of date after I changed the assets stuff. Let me update it

@vividviolet vividviolet force-pushed the integration-graphql branch 2 times, most recently from 834d5ff to e1169f5 Compare September 2, 2021 20:33
@vividviolet
Copy link
Member Author

@cecyc I just updated the branch and updated the instructions, the last step should be

  1. Visit http://localhost:8000/extensions/00000000-0000-0000-0000-000000000000/assets/main.js and verify that the JS bundle loads

Copy link
Contributor

@cecyc cecyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tophatted 👍

Copy link
Contributor

@t6d t6d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎩 ✅ 🚀

@vividviolet vividviolet changed the title Integration graphql Integration test with graphql Sep 3, 2021
@vividviolet vividviolet merged commit 7bd3de8 into main Sep 3, 2021
dmhenry pushed a commit that referenced this pull request Aug 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants