-
Notifications
You must be signed in to change notification settings - Fork 199
[scripts] Bump EP versions and use shopify_main #1119
Conversation
lib/project_types/script/layers/infrastructure/assemblyscript_task_runner.rb
Outdated
Show resolved
Hide resolved
sdk-version: "^7.0.0" | ||
toolchain-version: "^4.0.0" | ||
sdk-version: "^9.0.0" | ||
toolchain-version: "^5.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not related to this PR, but it looks like master
on the toolchain repo is still at version 4. If the changes in guest-serialization
are being published to NPM, then they should probably be merged to master
as well so that there's one source of truth for deployments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are using 2 different branch so that we can manage versions independently. If we had to push a fix for the old version, we can checkout master and do the changes there. Once we will be done with the msgpack changes, we'll overwrite master with the guest-serialization
branch.
FYI, you will have to update https://github.com/Shopify/shopify-app-cli/blob/b9cb34e1a5ba850af5ee4717974a4f5f9f55edad/lib/project_types/script/layers/infrastructure/assemblyscript_project_creator.rb#L59 and https://github.com/Shopify/shopify-app-cli/blob/b30efb57c16b4f408c8f38c045dd4d42690b0e22/lib/project_types/script/messages/messages.rb#L123. The main entrypoint no longer is |
Just fixed CLI to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also did a 🎩 and it looks good!
Use `import {Console} from '@shopify/scripts-sdk-as';` instead
WHY are these changes introduced?
This PR bumps the toolchain and SDK versions required by EPs. In addition, I've disabled the dependency check on
create
andpush
.WHAT is this pull request doing?
Update checklist