Skip to content
This repository has been archived by the owner on Jun 1, 2023. It is now read-only.

[scripts] Bump EP versions and use shopify_main #1119

Merged
merged 6 commits into from
Mar 12, 2021
Merged

Conversation

ifyouseewendy
Copy link
Contributor

WHY are these changes introduced?

This PR bumps the toolchain and SDK versions required by EPs. In addition, I've disabled the dependency check on create and push.

WHAT is this pull request doing?

Update checklist

  • I've added a CHANGELOG entry for this PR (if the change is public-facing)
  • I've considered possible cross-platform impacts (Mac, Linux, Windows).

@ifyouseewendy ifyouseewendy requested a review from a team as a code owner March 11, 2021 17:36
sdk-version: "^7.0.0"
toolchain-version: "^4.0.0"
sdk-version: "^9.0.0"
toolchain-version: "^5.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to this PR, but it looks like master on the toolchain repo is still at version 4. If the changes in guest-serialization are being published to NPM, then they should probably be merged to master as well so that there's one source of truth for deployments.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are using 2 different branch so that we can manage versions independently. If we had to push a fix for the old version, we can checkout master and do the changes there. Once we will be done with the msgpack changes, we'll overwrite master with the guest-serialization branch.

@maximebedard
Copy link
Contributor

@ifyouseewendy
Copy link
Contributor Author

Just fixed CLI to use shopify_main as the build entrypoint. I've 🎩 locally to create scripts for all EPs and all works well for shopify push

Copy link
Member

@jacobsteves jacobsteves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also did a 🎩 and it looks good!

Use `import {Console} from '@shopify/scripts-sdk-as';` instead
@ifyouseewendy ifyouseewendy changed the title [scripts] Bump EP versions [scripts] Bump EP versions and use shopify_main Mar 12, 2021
@ifyouseewendy ifyouseewendy merged commit fa312a9 into master Mar 12, 2021
@ifyouseewendy ifyouseewendy deleted the bump-ep-versions branch March 12, 2021 00:54
@ifyouseewendy ifyouseewendy temporarily deployed to rubygems March 12, 2021 01:00 Inactive
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants