-
Notifications
You must be signed in to change notification settings - Fork 199
Conversation
dd7bacf
to
32cad82
Compare
@@ -65,7 +65,7 @@ module Ruby | |||
end | |||
|
|||
module Node | |||
FROM = "12.0.0" | |||
FROM = "14.5.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated this to be aligned with the scripts requirements. Also, Node 12 EOL is in April, and this is just a recommendation anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, overall, is it still permitted to use Node 12 for running shopify-cli? It's not very clear if it is only a recommendation for certain parts and/or if it is mandatory to have at least 14.5 for other parts of shopify-cli? Please let us know. I'm running latest 12.22.10 and for the moment I cannot upgrade to Node 14+.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lorand-horvath it should work as before for now, it's just a recommendation. But some parts, like scripts, won't probably work with Node 12.
@@ -42,7 +42,7 @@ module Messages | |||
invalid_type: "The type %s is not supported. The only supported types are"\ | |||
" {{command:[ rails | node | php ]}}", | |||
help: <<~HELP, | |||
{{command:%s app create}}: Creates a ruby on rails app. | |||
{{command:%s app create}}: Creates a new project in a subdirectory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MeredithCastile we were showing this when you just run app create
:
$ shopify app create
shopify app create: Creates a ruby on rails app.
Usage: shopify app create [ rails | node | php ]
But it could also be a Node or PHP app... Let me know if you prefer another description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm. Maybe this?
Creates a basic app
Usage: shopify app create [ rails | node | php ]
Follow up question — Is there a default? Or will the system default to rails?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no default, we show the help when the type of app is not provided. I'll update the message, thanks!
WHY are these changes introduced?
Fixes #2039
After adding a check to show the recommended versions for Ruby and Node in #1945 and #2032, we are now requiring Node for all the commands, even when they don't really need it.
WHAT is this pull request doing?
check_version
method to only run it for the commands defining the recommended Node rage (recommend_default_node_range
).app create rails
andapp create node
, as it was before.We could add it as well for other commands like
app serve
, but we should check the type of app to avoid doing it for PHP. Also, we should carefully decide where we want to show it and check what operations really need it, so I'll leave it for another moment.How to test your changes?
Without Node:
mv /usr/local/bin/node /usr/local/bin/node.bk
)shopify login
With a wrong version:
12.0.0
)shopify extension push
Update checklist