This repository has been archived by the owner on Jun 1, 2023. It is now read-only.
Fix BaseGlob coverter to support multiple flags
#2122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karreiro
force-pushed
the
multiple-flags-glob
branch
from
6b56084
to
ecf34dd
Compare
2 tasks
karreiro
changed the title
BaseGlob coverter to support multiple flags
karreiro
force-pushed
the
multiple-flags-glob
branch
from
ecf34dd
to
284f420
Compare
karreiro
requested review from
a team,
jesalerno84,
isaacroldan,
pepicrft and
gonzaloriestra
and removed request for
a team,
jesalerno84,
isaacroldan,
pepicrft and
gonzaloriestra
5 tasks
macournoyer
approved these changes
Mar 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
The
BaseGlobconverter, introduced to support patterns without quotes, doesn't support many occurrences of the same flag.WHAT is this pull request doing?
This PR changes the
BaseGlobconverter to support multiple occurrences of the same flag.How to test your changes?
DEBUG=1 shopify-dev theme pull -d -x config/settings_schema.json -x config/settings_data.jsonBefore this PR:
After this PR:
Post-release steps
None.
Update checklist